HDDS-11370. Use GitHub's stale action to auto close inactive pull requests#9259
Conversation
|
@errose28 @adoroszlai please review this change. |
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for the patch, LGTM.
|
Should we consider increasing the number of days before marking it stale? Right now it’s set to 21 days of inactivity, which might be a bit aggressive. cc: @ChenSammi |
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Left a few comments but overall LGTM. Thanks @sarvekshayr for picking this up.
IMO the time windows are good. After 3 weeks of inactivity both reviewers and author will get a ping, at which point they can reconnect to decide what should happen to the PR. A simple comment by the author re-requesting a review would be enough to move it out of stale state. If nobody responds for another week then the PR is closed, which serves as more of a second ping than a final decision since it can still be re-opened at any time after that.
|
Thanks @sarvekshayr for the patch, @errose28 for the review. |
3 participants
What changes were proposed in this pull request?
See #7096
Currently we have a custom label that is manually applied to pull requests to mark them for auto closing, after which an auto-close action will come in later. Since this workflow seems to be leaving a lot of old PRs open, this Jira is to replace this workflow with https://github.com/actions/stale which does a similar thing but is completely automated.
What is the link to the Apache JIRA
HDDS-11370
How was this patch tested?
Tested on my fork.
PR marked as stale: sarvekshayr#47
close-stale-prs CI: https://github.com/sarvekshayr/ozone/actions/runs/19161704140